Follow coding-standard PER-CS2.0

[sreichel]

Description (*)

We run coding-rule checks since ages, but we never followed a common standard, We had some PSR2/12-rules for PHPCS, but settings for php-cs-fixer where different.

• follow https://www.php-fig.org/per/coding-style/
• use ONLY php-cs-fixer for codestyle-checks
• use PHPCS for ECG/PhpCompatibility checks

[addison74]

I wanted to check all the changes in the more than 3000 files. Although I have an extremely high-performance system, Chrome threw in the towel several times. The page already consumes 2.5 GB of RAM and is growing.

[sreichel]

No need to check manually.

Its only about code styling.

• adding comma to last array-element if its a multiline-list
• shorten empty classes
• adding space between (type)$valiable
• ...

See

• https://cs.symfony.com/doc/ruleSets/PSR1.html
• https://cs.symfony.com/doc/ruleSets/PSR2.html
• https://cs.symfony.com/doc/ruleSets/PSR12.html
• https://cs.symfony.com/doc/ruleSets/PER-CS1.0.html
• https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html

[sreichel]

Chrome threw in the towel several times. The page already consumes 2.5 GB of RAM and is growing.

Sorry for offopic, but what are you working with?

I only have an Intel Xeon E3-1231 with 16GB RAM and everything runs smooth. Even in VirtualBox.

[kiatng]

Ref https://www.php.net/manual/en/functions.arguments.php, trailing comma only supports in PHP8.

I can understand trailing comma is to reduce version control diff noise but this PR actually add more noise. It's good for project under development, I don't see benefit applying here. Why is it good for OpenMage?

[sreichel]

Ref https://www.php.net/manual/en/functions.arguments.php, trailing comma only supports in PHP8.

This is for function parameters only. The PR is about array items.

Why is it good for OpenMage?

We only had a couple of rules. Some from PSR2, some from PRS12. Not fish, not meat.

PSR-12 was accepted in 2019 and since then a number of changes have been made to PHP which have implications for coding style guidelines. Whilst PSR-12 is very comprehensive of PHP functionality that existed at the time of writing, new functionality is very open to interpretation. This PER, therefore, seeks to clarify the content of PSR-12 in a more modern context with new functionality available, make the errata to PSR-12 binding and further update it according to new data and language changes.

https://www.php-fig.org/per/coding-style/

[sreichel]

I can understand trailing comma is to reduce version control diff noise

Trailing comma is for better programming workflow!

You are on the last element of an array ... you hit ctrl + d to duplicate this line - to add an entry. How often you had to go to previous line to add that comma?

[sreichel]

But I tested here for PHP7.4, which throws error.

This is NOT part of the PR.

Trailing comma ...

Old ....

$a = [
    [],
    [] # no trailing comma
];

New ...

$a = [
    [],
    [], # trailing comma
];

Edit:

"PHP8-trailing-comma"

public function(
    $a,
    $b, #php8-only
)

Edit2:

All checks test for valid php7 syntax ;)

[sreichel]

Thats not that problem ... in https://onlinephp.io/c/0b1cf the error is on line 2. The comma in test(), not that comma in explode().

[sreichel]

It's this, I managed to screenshot before my browser crashed:

try https://patch-diff.githubusercontent.com/raw/OpenMage/magento-lts/pull/4372.diff