Fix issue #4501 Exception noise from OAuth and REST (API2 )

[kiatng]

Description (*)

See issue #4501. This PR added $shouldLog as an optional parameter in Mage_APi2_Exception, any code that extends it and overrides the constructor with the old signature would break.

Related Pull Requests

• see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

• fixes Exception noise from OAuth and REST (API2 ) #4501

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

any code that extends it and overrides the constructor with the old signature would break.

#4501 (comment)

How about to add _criticalNotLoggable() method and a new exception?

[kiatng]

any code that extends it and overrides the constructor with the old signature would break.

#4501 (comment)

How about to add _criticalNotLoggable() method and a new exception?

I have thought about new exception class. I am hesitant because I do not think there is any custom code that would extend it, if there is, it's easy to fix. This avoid adding more code.