Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block signal delivery to OpenBLAS-spawned threads #4054

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Block signal delivery to OpenBLAS-spawned threads #4054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion driver/others/blas_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
/*********************************************************************/

#include "common.h"
#include <stdbool.h>
#if defined(OS_LINUX) || defined(OS_NETBSD) || defined(OS_DARWIN) || defined(OS_ANDROID) || defined(OS_SUNOS) || defined(OS_FREEBSD) || defined(OS_OPENBSD) || defined(OS_DRAGONFLY) || defined(OS_HAIKU)
#include <dlfcn.h>
#include <errno.h>
Expand Down Expand Up @@ -669,6 +670,25 @@ int blas_thread_init(void){
if (thread_timeout_env > 30) thread_timeout_env = 30;
thread_timeout = (1 << thread_timeout_env);
}
/*
* Our threads should not deal with signals from the rest of the
* application - mask everything temporarily in this thread, so threads we
* launch will inherit that mask, and block all signal delivery. This
* should not fail, but make it best-effort.
*/
sigset_t sigset_block_all, sigset_restore;
ret = sigfillset(&sigset_block_all);
bool needSigmaskRestore = false;
if (ret != 0) {
fprintf(STDERR, "OpenBLAS blas_thread_init: sigfillset failed to block signals: %s", strerror(ret));
} else {
ret = pthread_sigmask(SIG_BLOCK, &sigset_block_all, &sigset_restore);
if (ret != 0) {
fprintf(STDERR, "OpenBLAS blas_thread_init: failed to block signals: pthread_sigmask: %s", strerror(ret));
} else {
needSigmaskRestore = true;
}
}

for(i = 0; i < blas_num_threads - 1; i++){

Expand All @@ -686,7 +706,7 @@ int blas_thread_init(void){
&blas_thread_server, (void *)i);
#endif
if(ret!=0){
struct rlimit rlim;
struct rlimit rlim;
const char *msg = strerror(ret);
fprintf(STDERR, "OpenBLAS blas_thread_init: pthread_create failed for thread %ld of %d: %s\n", i+1,blas_num_threads,msg);
#ifdef RLIMIT_NPROC
Expand All @@ -695,6 +715,11 @@ int blas_thread_init(void){
"%ld current, %ld max\n", (long)(rlim.rlim_cur), (long)(rlim.rlim_max));
}
#endif
if (needSigmaskRestore) {
// Attempt to restore sigmask if required, before raising SIGINT.
pthread_sigmask(SIG_SETMASK, &sigset_restore, NULL);
needSigmaskRestore = false;
}
if(0 != raise(SIGINT)) {
fprintf(STDERR, "OpenBLAS blas_thread_init: calling exit(3)\n");
exit(EXIT_FAILURE);
Expand All @@ -708,6 +733,14 @@ int blas_thread_init(void){
#endif

blas_server_avail = 1;

if (needSigmaskRestore) {
// Attempt to restore sigmask if required, before raising SIGINT.
ret = pthread_sigmask(SIG_SETMASK, &sigset_restore, NULL);
if (ret != 0) {
fprintf(STDERR, "OpenBLAS blas_thread_init: failed to restore signal mask: pthread_signask: %s", strerror(ret));
}
}
}

UNLOCK_COMMAND(&server_lock);
Expand Down