Update to use safe scaling algorithm from Reference-LAPACK PR 527 #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-ch
reviewed
Jul 13, 2023
interface/rotg.c
Outdated
| *C = ONE; | ||
| *S = ZERO; | ||
| *DA = ZERO; | ||
| DA = ZERO; |
There was a problem hiding this comment.
I think this is unintentional.
There was a problem hiding this comment.
Certainly hope so...but this is just a dump of my first draft, too much work too little brain right now
vladimir-ch
reviewed
Jul 13, 2023
interface/rotg.c
Outdated
| @@ -112,7 +112,7 @@ void CNAME(FLOAT *DA, FLOAT *DB, FLOAT *C, FLOAT *S){ | |||
| if (adb == ZERO) { | |||
| *C = ONE; | |||
| *S = ZERO; | |||
| DA = ZERO; | |||
| *DA = ZERO; | |||
There was a problem hiding this comment.
I'm not sure about this change. If the input vector is [a,0], then the rotation is the identity and the rotated vector [a,0]. Maybe your initial intention was to delete the whole line as in the other #if branch?
There was a problem hiding this comment.
yeah, looks like a cut-n-paste gone wrong. thanks for your vigilance - still haven't run any tests with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes original topic of #4130