Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content to Specifications menu #486

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Add content to Specifications menu #486

merged 5 commits into from
Jan 29, 2025

Conversation

jpradocueva
Copy link
Member

No description provided.

@jpradocueva jpradocueva changed the base branch from issue-docs-193 to mockup January 26, 2025 19:10
subtitle: |
Axios gets you smarter, faster on what matters.
text: |
This is a representation of [additional](https://www.nasa.gov/) field for text, if it is needed. It also has a *full Markdown capability*.
Copy link
Collaborator

@FroudeDescartes FroudeDescartes Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nuxt] [NuxtLink] You can't nest one inside another . This will cause a hydration error on client-side. You can pass the custom prop to take full control of the markup.

@jpradocueva
This error appears because we used ShMicroCard and added a link inside of text prop. Error is presented because we already have whole component wrapped in a anchor-like component and while we can insert a link inside of a prop, Nuxt notifys us that there might be some issues due to that. I will see how to resolve this in a component scope. For now, I have just changed ShCard to be used instead of ShMicroCard

@FroudeDescartes
Copy link
Collaborator

This looks good, but I will wait for the merge to be done by tomorrow.

@FroudeDescartes FroudeDescartes self-assigned this Jan 28, 2025
Copy link
Collaborator

@FroudeDescartes FroudeDescartes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of testing today, this branch seems to be working correctly, without any crashes or errors.
Given that, I will merge it to mockup

@FroudeDescartes FroudeDescartes merged commit 4b45f01 into mockup Jan 29, 2025
1 check passed
@FroudeDescartes FroudeDescartes deleted the specifications branch January 29, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants