Add trace ID to local logs in Karaf so we can relate local transactions with those on the cloud side #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus.getNumber If there was a null TraceStatus, UNRECOGNIZED was returned in convertToTraceStatus, but UNRECOGNIZED couldn't be converted later to an span status. OpenTelemetry only supports three kinds of span statuses: - Unset - Ok - Error -- https://opentelemetry.io/docs/concepts/signals/traces/#span-status Simplified the status handling to treat everything as Ok or Error based on the gRPC status code.
It was confusing to see the "received cloud log with" log message locally but not see anything upstream. Until I looked at the code. It was easy to not special case this. Note that I tweaked the loop that works through the queue to do/while to avoid a loop where the queue always have something in it from the SendTraces call that it just did.
This is helpful for diagnosing server-side issues in TSaaS when bringing up the cloud plugin. There's still more to do for other non-tsaas-gateway calls, both within the cloud plugin and on backend services in the cloud, but I think this gets us pretty good coverage for calls into the tsaas-gateway.
|
SonarCloud Quality Gate failed. |
Without this, I got:
failed uploading test results: File: home/circleci/junit/failsafe-summary.xml had the following problems:
* invalid top level element: failsafe-summary
-- source: https://app.circleci.com/pipelines/github/OpenNMS/opennms-cloud-plugin/883/workflows/d6d81040-80ec-4342-8fda-1e1fd9a37a1c/jobs/2104?invite=true#step-106-31
Snagged this line from Horizon classic: https://github.com/OpenNMS/opennms/blob/develop/.circleci/main/commands/executions/run-integration-tests.yml#L38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs and makes a supportability improvement:
It adds tracing for a few more calls:
And lastly, it also passes the gRPC status code upstream (the span status code only has three allowable values, so it cannot be used for this):