NMS-16116: Update node structure page to accept query strings #6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synqotik
deleted the
jira/NMS-16116-node-structure-handle-query-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Node Structure page to accept query strings and convert them to query filters.
When certain query strings are included in the node Vue page link, they will be converted and added to the
nodeStructurepiniastore and query relaunched, and query string removed from the URL (so it's doesn't get re-processed). Query strings will come from legacy pages that currently link to the legacy node list page.Refactored how the search works, basically search updates are saved in the
piniastore and thewatchinNodesTable.vuewatches for those changes. Otherwise updates were coming from multiple places and clobbering each other.Refactored
utils.tsinto separate hooks, it was getting unwieldy.Still more work to be done on this but will follow up in a subsequent PR. Targeting
developas it's all on the new Vue page.External References