NMS-16185: upgrade to latest protobuf #6780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerRick
requested review from
cgorantla,
fooker,
synqotik and
christianpape
fooker
approved these changes
Oct 17, 2023
fooker
previously approved these changes
Oct 17, 2023
RangerRick
force-pushed
the
ranger/protobuf-upgrade
branch
2 times, most recently
from
23d2089 to
72bba17
Compare
RangerRick
force-pushed
the
ranger/protobuf-upgrade
branch
from
72bba17 to
d3c188f
Compare
|
Just gonna punt this, I'm running into weird feature interactions, and right now it's Good Enough to use the existing (slightly old) drools 8 we have in 32+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest protobuf (3.24.4) and re-generates protobuf-based java code.
This is a prerequisite to (nicely) backporting the latest drools 8 to
foundation-2023.It also includes some general cleanup of the pom files so they match each other better and use variables for versions wherever possible.
External References