Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-16149: Added confd to Sentinel #6820

Merged
merged 6 commits into from
Nov 10, 2023
Merged

NMS-16149: Added confd to Sentinel #6820

merged 6 commits into from
Nov 10, 2023

Conversation

christianpape
Copy link
Contributor

RangerRick
RangerRick previously approved these changes Oct 31, 2023
View reviewed changes
indigo423
indigo423 previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@indigo423 indigo423 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RangerRick @christianpape The minion-config-schema.yml was introduced just for the Minion portal, we read this schema file and use it dynamically to create a user interface in the cloud portal to allow users to configure a Minion. We don't have a portal to configure the Sentinel, I don't think we should introduce a sentinel-config-schema.yml we actually don't really need. What do you think?

@RangerRick
Copy link
Contributor

@indigo423 ah, that's true, shouldn't be necessary

@mmahacek
Copy link
Contributor

Instead of a read me file, the content should be added to the docs

@christianpape
Copy link
Contributor Author

@RangerRick @christianpape The minion-config-schema.yml was introduced just for the Minion portal, we read this schema file and use it dynamically to create a user interface cloud portal to allow users to configure a Minion. We don't have a portal to configure the Sentinel, I don't think we should introduce a sentinel-config-schema.yml we actually don't really need. What do you think?

Ok.

@christianpape christianpape dismissed stale reviews from indigo423 and RangerRick via 5a8c13b November 2, 2023 06:56
@github-actions github-actions bot added the docs label Nov 2, 2023
@github-actions github-actions bot requested a review from Bonrob2 November 2, 2023 06:56
Bonrob2
Bonrob2 suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates to the docs file. Thank you!

docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
docs/modules/reference/pages/configuration/sentinel-features.adoc Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from Bonrob2 November 3, 2023 06:53
Bonrob2
Bonrob2 previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs LGTM. Thank you!

indigo423
indigo423 previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@indigo423 indigo423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

opennms-container/sentinel/.gitignore Outdated
@@ -1 +1,2 @@
sentinel-config-schema.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop this one as well, -1 line 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@christianpape christianpape dismissed stale reviews from indigo423 and Bonrob2 via fc3a1c6 November 3, 2023 15:50
@github-actions github-actions bot requested a review from Bonrob2 November 3, 2023 15:50
RangerRick
RangerRick suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the build is failing because of getting rid of the extraneous schema

@christianpape christianpape merged commit 8e3ba5f into foundation-2023 Nov 10, 2023
4 checks passed
@christianpape christianpape deleted the jira/NMS-16149 branch November 10, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

@indigo423 indigo423 indigo423 left review comments

@mmahacek mmahacek Awaiting requested review from mmahacek

@Bonrob2 Bonrob2 Awaiting requested review from Bonrob2

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christianpape @RangerRick @mmahacek @indigo423 @Bonrob2