NMS-15717: DeviceConfig via Minion fails if sshScript output contains control characters. #7537
+277
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Junaid-Khan-Nant
commented
Nov 19, 2024
Junaid-Khan-Nant
commented
- Jira (Issue Tracker): https://opennms.atlassian.net/browse/NMS-15717
…s control characters.
christianpape
changed the title
…s control characters.(updated).
…s control characters.(updated test).
|
Hi @cgorantla , I have tried it with Juniper. Please see the results in screenshots.
Also tried with dcb-trigger using karaf and minion facing below errors:
|
|
Hi @cgorantla , please see the screenshots. |
indigo423
changed the title
cgorantla
reviewed
Jan 13, 2025
There was a problem hiding this comment.
@Junaid-Khan-Nant Did you try with latest versions of eclipse persistence ? Can you have a branch that shows upgraded versions still fail these tests ?
I would prefer to avoid customizations for these core things.
christianpape
requested changes
Jan 15, 2025
features/poller/api/src/main/java/org/opennms/netmgt/poller/EscapeSequenceAdapter.java
Outdated
Show resolved
Hide resolved
features/poller/api/src/main/java/org/opennms/netmgt/poller/EscapeSequenceAdapter.java
Outdated
Show resolved
Hide resolved
features/poller/api/src/main/java/org/opennms/netmgt/poller/EscapeSequenceAdapter.java
Outdated
Show resolved
Hide resolved
features/poller/api/src/main/java/org/opennms/netmgt/poller/EscapeSequenceAdapter.java
Outdated
Show resolved
Hide resolved
features/poller/api/src/test/java/org/opennms/netmgt/poller/DeviceConfigTest.java
Outdated
Show resolved
Hide resolved
features/poller/api/src/test/java/org/opennms/netmgt/poller/EscapeSequenceAdapterTest.java
Outdated
Show resolved
Hide resolved
…s control characters.(update code).
christianpape
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.