Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16970: Implement framework for collecting initial system data #7556

Closed
wants to merge 4 commits into from

Conversation

MusaidAli
Copy link
Contributor

@MusaidAli MusaidAli commented Dec 9, 2024

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

@MusaidAli
Copy link
Contributor Author

Screenshot from 2024-12-09 21-28-10
Screenshot from 2024-12-09 21-28-19

@MusaidAli MusaidAli requested a review from synqotik December 9, 2024 17:24
@smunir-onms smunir-onms requested review from smunir-onms and removed request for synqotik, smunir-onms and cgorantla December 9, 2024 17:45
@smunir-onms smunir-onms marked this pull request as draft December 9, 2024 17:46
@indigo423
Copy link
Member

indigo423 commented Dec 10, 2024

I don't understand the value of adding free physical memory to the "usage statistics sharing". This metric has a very short lifetime of meaning. It seems like the usage statistics feature which had the intention to understand the usage of the tool, and is now degrading to a system diagnostics tool. This is a completely different purpose. Especially in the context of monitoring engineers can opt-in or opt-out to share this information. Once the network monitoring engineer opted-in this information will be shared daily.

A tool for system diagnostics exists in the tool. Its purpose is to generate all the necessary information to reduce the time to troubleshoot and fix a problem in OpenNMS without having access to the system. It is triggered on a request base and can take some time because it collects very detailed system and environment information. The shared information security is within the boundary of the support issue. The free memory usage in a request like this would have value in this context. A support engineer asked to change some JVM settings and he want's see how that affected the used memory in a given situation.

Screenshot 2024-12-10 at 10 52 51

These are two very different features and shouldn't be mixed. Additionally, you should review my comment in https://opennms.atlassian.net/browse/NMS-16958?focusedCommentId=117013 regarding the risk of exposing internal infrastructure information.

@MusaidAli MusaidAli closed this Dec 10, 2024
@MusaidAli MusaidAli deleted the ma/jira/NMS-16970 branch December 10, 2024 10:15
@MusaidAli MusaidAli changed the title NMS-16970 : Implement framework for collecting initial system data. Implement framework for collecting initial system data. Dec 10, 2024
@MusaidAli MusaidAli changed the title Implement framework for collecting initial system data. ... Dec 10, 2024
@MusaidAli MusaidAli changed the title ... A Dec 10, 2024
@MusaidAli MusaidAli removed the request for review from smunir-onms December 10, 2024 10:20
@MusaidAli MusaidAli restored the ma/jira/NMS-16970 branch December 10, 2024 10:35
@MusaidAli MusaidAli reopened this Dec 10, 2024
@MusaidAli MusaidAli changed the title A NMS-16970: Implement framework for collecting initial system data Dec 10, 2024
@MusaidAli MusaidAli closed this Dec 13, 2024
@MusaidAli MusaidAli deleted the ma/jira/NMS-16970 branch December 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants