Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile maintenance #101

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Lockfile maintenance #101

merged 1 commit into from
Sep 30, 2024

Conversation

Sporiff
Copy link
Member

@Sporiff Sporiff commented Sep 28, 2024

Addresses security issues with some npm packages.

Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for openpodcastapi ready!

Name Link
🔨 Latest commit 3174f48
🔍 Latest deploy log https://app.netlify.com/sites/openpodcastapi/deploys/66f804a6cc04560008d8e92e
😎 Deploy Preview https://deploy-preview-101--openpodcastapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@georgkrause georgkrause merged commit 8a5f786 into main Sep 30, 2024
5 checks passed
@georgkrause georgkrause deleted the lockfile-maintenance branch September 30, 2024 12:59
@keunes
Copy link
Member

keunes commented Nov 3, 2024

I have different versions on my local machine. Would it work & be safe if we add this file to .gitignore? @Sporiff @georgkrause

@georgkrause
Copy link
Collaborator

@keunes What different versions do you have? Different dependencies? Or different lock files?

The purpose of the lock file is making sure everyone is working in the same environment, which is why you wouldn't usually add it to a gitignore. However, in our case it might be not as problematic to do so. Solving the underlying issue might be the better idea anyways :)

@keunes
Copy link
Member

keunes commented Nov 3, 2024

Hmmm, right.

I had a bunch of changes in my file showing up in VS Code. Don't know why that was. Now it's not happening any-more, and I understand that it shouldn't be happening (when installing/building, it should take whatever is defined in the file).

Sorry for the noise & thanks for the info @georgkrause!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants