Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude gpodder from lychee #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exclude gpodder from lychee #116

wants to merge 1 commit into from

Conversation

keunes
Copy link
Member

@keunes keunes commented Nov 3, 2024

Since v2 (#105), Lychee-action automatically fails a PR if a link-check doesn't work. Probably a good thing, though we have one particular website that will often fail. Therefore excluding that website.

Doing via exclude argument rather than creating a .lychee-ignore file because (at this point) we're only excluding a single site (and adding a file is polluting more than helpful).

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for openpodcastapi ready!

Name Link
🔨 Latest commit 3c06afb
🔍 Latest deploy log https://app.netlify.com/sites/openpodcastapi/deploys/672766f87238cd0008ff0625
😎 Deploy Preview https://deploy-preview-116--openpodcastapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@georgkrause
Copy link
Collaborator

we have one particular website that will often fail

If this is the case and we don't have any reason to expect improvements or means to improve the situation, I'd say we should create a mirror and link to that. Because if the page isn't available on a regular base, why should we link there? Its not reliably useful to our users.

@keunes
Copy link
Member Author

keunes commented Nov 3, 2024

It's regularly offline but often still works. But you have a good point.

I just realised that the link only exists in our Readme file - not very prominent. A mirror is probably not worth it. I guess that (instead of adjusting lychee) we could:

Any preference?

@georgkrause
Copy link
Collaborator

@keunes Using archive.org was basically what I meant by "mirroring", I didn't want to host a mirror on our own. But I wasn't sure about the state of archive.org at the moment and didn't knew if there is already a copy there. But if there is, we should probably link there. Github would be also fine.

I think our project is heavily inspired by GPodder and dropping the link is something I wouldn't be comfortable with. I also think we should promote the link to our Website in order to appreciate their work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants