merging braille-printer-application with cups-filters code #1
Conversation
| @@ -5,7 +5,7 @@ doc_DATA = \ | |||
| AUTHORS \ | |||
| COPYING \ | |||
| CHANGES.md \ | |||
| CHANGES-1.x.md \ | |||
| CHANGES-cups-filter.md \ | |||
There was a problem hiding this comment.
CHANGES-cups-filters.md it is cups-filters, not cups-filter.
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
You can remove LICENSE and NOTICE from this subdir. they are already in the main directory.
| @@ -0,0 +1,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
Please update the copyright/author name part of NOTICE in the main directory. Do not add an extra NOTICE file here.
| @@ -0,0 +1,131 @@ | |||
| Braille Printer Application | |||
There was a problem hiding this comment.
No extra README.md in this sub-directory needed. Merge with the main directory's README.md. Let it have a section for the Printer Application and a section for the classic driver, the Printer Application, being the default/preferred method.
| // parameters | ||
| } brf_spooling_conversion_t; | ||
|
|
||
| static brf_spooling_conversion_t brf_convert_pdf_to_brf = |
There was a problem hiding this comment.
- Does this actually convert PDF to BRF or is this converting text to BRF?
- This structure
brf_convert_pdf_to_brfis nowhere used in the code. So do we really need it?
|
|
||
| for (conversion = | ||
| (brf_spooling_conversion_t *) | ||
| cupsArrayFirst(spooling_conversions); |
There was a problem hiding this comment.
Where did spooling_conversions get populated?
| cupsArrayAdd(chain, &(conversion->filters[i])); | ||
| cupsArrayAdd(chain,&(filter_data_ext)); | ||
| } | ||
|
|
There was a problem hiding this comment.
The filter chain chain contains conversion filters from conversion. These must be of type cf_filter_filter_in_chain_t, but filter_data_ext is of type cf_filter_external_t. Also does it have to be added to chain after each of the conversion filters?
|
|
||
|
|
||
| if (brf_drivers[i].device_id) | ||
| { |
There was a problem hiding this comment.
brf_drivers[] has only 1 entry without device ID, so autoadd_cb() always returns NULL. Did you test the code? Or only compile it?
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You need to return the core here.
| } | ||
|
|
||
| // Pages per minute | ||
| data->ppm = 60; |
There was a problem hiding this comment.
Braille embossers seem to be really fast ...
There was a problem hiding this comment.
Heh :)
Indeed it's rather 1 that should be set. Yes, it typically takes one minute to emboss a whole page...
| // Color values... | ||
| data->color_supported = PAPPL_COLOR_MODE_AUTO | PAPPL_COLOR_MODE_MONOCHROME; | ||
| data->color_default = PAPPL_COLOR_MODE_MONOCHROME; | ||
| data->raster_types = PAPPL_PWG_RASTER_TYPE_BLACK_8; // to be done just guess |
There was a problem hiding this comment.
I raster input really 8-bit grayscale? And not 1-bit bi-level? (Depends on the filters)
@tillkamppeter could you review it and let me know if any changes are required