Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite: If holding supported, add a new print job for cancelling #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test suite: If holding supported, add a new print job for cancelling #438

wants to merge 1 commit into from

Commits on Jan 26, 2024

  1. Test suite: If holding supported, add a new print job for cancelling 

    On some quicker machines the print-job operation finishes quicker than
we can cancel it in the test - so add job-hold-until job template
attribute if the printer supports it, which will hold the job until it
is cancelled by the next test.

The next test passes because it has both statuses (correct and error one)
as expected, but cupsd generates an additional error in log if the job
cancelling fails, which would be more dirty to cover in run-stp-test.sh.

There is a loophole when the error is still generated - if the printer/machine
is quick enough to finish the job, but the machine/printer doesn't support job
holding at the same time. IMHO the current patch should cover most cases.
    @zdohnal
    zdohnal committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    851dc81 View commit details
    Browse the repository at this point in the history