Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Osprey #703

Merged
merged 4 commits into from
May 10, 2020
Merged

Added the Osprey #703

merged 4 commits into from
May 10, 2020

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender commented Apr 23, 2020

Followup of #682. Closes #699.

@sorcerer86pt
Copy link

Osprey works, but the missiles don't do enough damage. Check the video bellow:

Osprey damage

Copy link

@sorcerer86pt sorcerer86pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balance Osprey damage to submarines

@Mailaender
Copy link
Member Author

It's the exact damage values from rules.ini.

@sorcerer86pt
Copy link

Ok, but have the other naval units have the same values? See the video, not even 3 ospreys can deal with 1 submarine.

@Mailaender
Copy link
Member Author

Yes. Updated this a bit with values I found in rules.ini, but none increase the damage against subs. You can type utility.cmd --extract rules.ini (it will be put into the engine folder) to check for yourself.

@pgwipeout
Copy link

pgwipeout commented May 1, 2020 via email

@Mailaender
Copy link
Member Author

Yes, I think the submarine immediately surfacing was the problem as it invalidated the target type. Should be fixed now.

@sorcerer86pt
Copy link

ok, will test this one as it is.

@sorcerer86pt
Copy link

sorcerer86pt commented May 1, 2020

ok, it attacks well now, but in single unit. Don't knwo why, but when a group of destroyers try to attack a sub, only 1 osprey attacks. The others take flight but don't attack.

Also sometime i've seen destroyers using the cannon on submarines. Don't know if they were submerged on not.

See the video below:

Osprey group

@Mailaender
Copy link
Member Author

Fixed targeting with multiple destroyers.

@sorcerer86pt
Copy link

Tested it know: it works 100%.. great work

sorcerer86pt
sorcerer86pt previously approved these changes May 1, 2020
@Mailaender
Copy link
Member Author

Updated.

@Mailaender Mailaender removed the PR: Fixup requested A minor change is required label May 2, 2020
mods/ra2/audio/voices.yaml Outdated Show resolved Hide resolved
mods/ra2/rules/allied-naval.yaml Outdated Show resolved Hide resolved
mods/ra2/rules/aircraft.yaml Outdated Show resolved Hide resolved
@abcdefg30 abcdefg30 added the PR: Fixup requested A minor change is required label May 2, 2020
@Mailaender Mailaender removed the PR: Fixup requested A minor change is required label May 2, 2020
@Mailaender Mailaender force-pushed the osprey branch 2 times, most recently from a917abe to 518aadd Compare May 2, 2020 17:51
@abcdefg30
Copy link
Member

Ah damn. This needs a rebase now.

@Mailaender
Copy link
Member Author

Rebased.

@abcdefg30
Copy link
Member

Hm, odd. Something seems not right with the spawn/land offset now:
destOffset

@Mailaender
Copy link
Member Author

Yes, exit offsets don't work properly. If you set it correct for one side, it will be broken if the ship rotates, so I kept it in the middle until it is fixed. The carrier has the same problem, but it isn't that noticeable because the spawn point is centered.

@abcdefg30
Copy link
Member

Hm, ok. Opened #719 so we keep track.

@abcdefg30 abcdefg30 merged commit 0bd1e28 into OpenRA:master May 10, 2020
@Mailaender Mailaender deleted the osprey branch May 10, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroyer not attacking submarine with correct weapon
5 participants