Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename custom music and mark as compat objects #251

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

ZeeMaji
Copy link
Contributor

@ZeeMaji ZeeMaji commented Oct 8, 2023

Renames both of the custom music 1/2 styles to legacy custom music 1/2 and marks them as compatibility objects.

Closes #228

@Gymnasiast
Copy link
Member

I’m pondering whether it would be a good idea to also clear the translations. After all, they are now no longer correct. OTOH, they are not that incorrect.

@ZeeMaji
Copy link
Contributor Author

ZeeMaji commented Oct 9, 2023

From what i can remember, previous object PRs that changed the en-gb string for an object never cleared the other translations (eg: the path object renames from a year or so ago) and just left them as is until they were updated in the localisation repo.

To be honest in this case it seems pretty minor as the en-gb name was only slightly changed so the translations are still mostly correct, just slightly oudated.

@Gymnasiast
Copy link
Member

Yeah, fair enough.

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks ok, though tbh I don't really know what the impact is

@ZeeMaji
Copy link
Contributor Author

ZeeMaji commented Oct 14, 2023

This will make the old custom music objects (the ones that handle vanilla's custom music implementation) compatibility objects, which means they won't be selectable from the object selection window and can only be imported from old parks and deselected. They don't really serve much of a purpose beyond compatibility with old parks since music objects are a far better way of doing custom music now so marking the old custom music objects as compatibility objects seems sensible.

@tupaschoal tupaschoal merged commit 6c96dc4 into OpenRCT2:master Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename CUSTOM1 and CUSTOM2 to "legacy custom music" and flag them as compatibility objects
3 participants