Re-introduce RCT1 road #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gymnasiast
force-pushed
the
feature/rct1-road
branch
from
96775c2
to
9091aaa
Compare
Gymnasiast
force-pushed
the
feature/rct1-road
branch
from
9091aaa
to
9fddc0b
Compare
ZeeMaji
approved these changes
Nov 24, 2023
tupaschoal
reviewed
Nov 29, 2023
| "objectType": "footpath_surface", | ||
| "properties": { | ||
| "editorOnly": true, | ||
| "noSlopeRailings": true |
There was a problem hiding this comment.
Why not just adding this property to the existing rct2 road?
There was a problem hiding this comment.
That would affect how existing parks look, and that always attracts complaints. So it has basically become policy to make sure all object changes are fully backwards compatible.
The way I did it, both RCT1 and RCT2 road will be drawn correctly, but only one will show up in the Object Selection, so it doesn’t clutter things up.
tupaschoal
approved these changes
Nov 29, 2023
|
Note that in the next objects release, the S4 import table will need to be updated to use the new RCT1 road object when importing S4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RCT2 road draws handrails in the tunnels and on slopes (because RCT2 was programmed to do this with all paths), which makes it look weird and also means that roads in RCT1 scenarios don’t always look like they should.
Here are the two side by side (RCT2 on the left, RCT1 on the right):