Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wall versions of beta terrain edges #344

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

fidwell
Copy link
Contributor

@fidwell fidwell commented Aug 2, 2024

Resolves #340. Created new wall objects that match the texture of the two beta terrain edges.

image

I wasn't sure what to name these. The terrain textures are called Brick (Brown) and Rock (Brown), so I went with Brick wall (Brown) and Rock wall (Brown) to match. Open to other suggestions.

For the object ids, the terrain textures are rct1beta.terrain_edge.brick and rct1beta.terrain_edge.rock, but the walls aren't from the beta, but maybe the names should match anyway? They're easy to change regardless.

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Aug 3, 2024

I'm a bit unsure if it would make sense to include the rock walls as there's no wall version of the final/RCT2 rock edge.

For the names i would just shorten them to "Brick Wall" and "Rock Wall" or even just "Wall" as the wall names in vanilla are pretty generic.

For the object ids should remain "official" as they were not a part of the rct1 beta, they're just official additions based on the beta assets.

@fidwell
Copy link
Contributor Author

fidwell commented Aug 3, 2024

I didn't even consider that some of the terrain edges don't have corresponding walls. I probably wouldn't have made the rock wall if I'd thought about it.

If anyone feels strongly about not having them, that's fine by me.

@tbarford
Copy link

tbarford commented Aug 4, 2024

Maybe add that wall texture as a scenery wall, too?

@deurklink
Copy link
Contributor

I think it would be really nice to have the other wall edge textures as scenery too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenery wall versions of beta brick edge
4 participants