-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle both invalid trigrams and uics as invalid op #10471
base: dev
Are you sure you want to change the base?
Conversation
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10471 +/- ##
==========================================
+ Coverage 81.61% 82.06% +0.45%
==========================================
Files 1067 787 -280
Lines 105535 78205 -27330
Branches 727 728 +1
==========================================
- Hits 86128 64182 -21946
+ Misses 19366 13984 -5382
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, ty for this fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder comment, just so that GitHub gets this PR off my TODO list :P
See the discussion above.
21f9f27
to
37a6c2f
Compare
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new logic looks good!
It seems like the usePathfinding()
hook has a similar bug: handleInvalidPathItems()
there checks trigrams only. There is a TODO:
// TODO: we currently only handle invalid pathSteps with trigram. We will have to do it for trackOffset, opId and uic too.
Are you feeling up for adding a new commit to fix that bug and do something similar to the logic in this PR, or do you prefer to leave that for later?
Signed-off-by: Achraf Mohyeddine <[email protected]>
8c32833
to
6021ad9
Compare
Closes #10116