front: enable power restrictions merge #10561
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10561 +/- ##
==========================================
- Coverage 81.91% 81.89% -0.02%
==========================================
Files 1079 1079
Lines 107233 107331 +98
Branches 729 729
==========================================
+ Hits 87840 87901 +61
- Misses 19353 19390 +37
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/8850-merge-power-restrictions
branch
from
cecdc25 to
a487ade
Compare
…ot be retrived Signed-off-by: Clara Ni <[email protected]>
… restrction range When editing the first power restriction range, an extra empty range was added (range from 0 to 0). This was a bug and should not occur anymore. Signed-off-by: Clara Ni <[email protected]>
…alid Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/8850-merge-power-restrictions
branch
from
a487ade to
5e2dc72
Compare
| ); | ||
|
|
||
| let newPowerRestrictionRanges: PowerRestriction[] = []; | ||
| let newPathSteps: PathStep[] = [...state.pathSteps].map((step) => step!); |
There was a problem hiding this comment.
nit : we can probably add an early check and throw if a path step is null because we don't have access to the power restriction tool if origin or destination are null (meaning there is no pathfinding)
There was a problem hiding this comment.
interval.editor.mov
It seems if you cut the ranges multiple times and merge two of them, you're not able to merge the ranges with a position lower than the first cut.
It does work for the range positioned after, and also for ranges two steps below the first cut.
EDIT: tried again, and was able to merge ranges before the first cut (at least 2 steps before the first cut), except for the range that is right before the first cut.
closes #8850