lmr: putting ma100 as default value in the speedlimittag selector #9987

Caracol3 · 2024-12-09T16:11:58Z

closes #9584
Edit: 'No speedLimit tag' should only be displayed in debug mode on stdcm page

codecov-commenter · 2024-12-09T16:14:44Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (42f1939) to head (1a2ec20).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #9987   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files        1078     1078           
  Lines      107544   107555   +11     
  Branches      733      733           
=======================================
+ Hits        88114    88126   +12     
+ Misses      19391    19390    -1     
  Partials       39       39

Flag	Coverage Δ
editoast	`74.39% <ø> (+<0.01%)`	⬆️
front	`89.42% <100.00%> (+<0.01%)`	⬆️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.50% <ø> (ø)`
tests	`88.14% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx

Akctarus

Tested, I left a comment but apart that, LGTM !
I approve the PR and let you make the quick fix

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx

front/src/common/SpeedLimitByTagSelector/useStoreDataForSpeedLimitByTagSelector.ts

front/tests/pages/stdcm-page-model.ts

Yohh

just to clean a little: can you rename the locator codeCompoField to speedLimitTagField

clarani

LGTM ✅

front/tests/pages/stdcm-page-model.ts

Maymanaf

LGTM

- nospeedlimittag is only displayed in debugmode in stdcm - adapt stdcm tests to be coherent with the default composition code Signed-off-by: Mathieu <[email protected]>

Caracol3 requested review from Math-R and Akctarus December 9, 2024 16:11

Caracol3 requested a review from a team as a code owner December 9, 2024 16:11

github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 9, 2024

Math-R reviewed Dec 9, 2024

View reviewed changes

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from b76e9d1 to 1c3dbc1 Compare December 10, 2024 10:08

Caracol3 requested a review from Math-R December 10, 2024 10:14

Akctarus approved these changes Dec 10, 2024

View reviewed changes

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved

clarani requested changes Dec 12, 2024

View reviewed changes

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 1c3dbc1 to 5ea2d08 Compare December 13, 2024 09:20

Caracol3 requested a review from clarani December 16, 2024 10:14

clarani reviewed Dec 16, 2024

View reviewed changes

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 5ea2d08 to 60332dd Compare December 16, 2024 21:25

Caracol3 requested a review from clarani December 16, 2024 21:25

clarani reviewed Dec 17, 2024

View reviewed changes

front/src/common/SpeedLimitByTagSelector/useStoreDataForSpeedLimitByTagSelector.ts Outdated Show resolved Hide resolved

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 60332dd to 928052a Compare December 17, 2024 15:42

Caracol3 requested a review from clarani December 17, 2024 15:44

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 928052a to 116ecc9 Compare December 18, 2024 09:45

Caracol3 requested a review from a team as a code owner December 18, 2024 09:45

Yohh reviewed Dec 18, 2024

View reviewed changes

front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved

Yohh reviewed Dec 18, 2024

View reviewed changes

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch 3 times, most recently from dfef8b1 to b4c4432 Compare December 18, 2024 11:20

Caracol3 requested a review from Yohh December 18, 2024 11:21

Yohh mentioned this pull request Dec 18, 2024

front: add towed rolling stock e2e test #10025

Merged

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from b4c4432 to 4673960 Compare December 18, 2024 13:51

Math-R approved these changes Dec 19, 2024

View reviewed changes

Yohh approved these changes Dec 19, 2024

View reviewed changes

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from a4aa06f to 4e734a9 Compare December 19, 2024 14:59

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 8cced31 to 335f5aa Compare January 17, 2025 14:14

SharglutDev requested a review from clarani January 20, 2025 11:05

clarani approved these changes Jan 31, 2025

View reviewed changes

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch 3 times, most recently from ad4fcc7 to 8125119 Compare February 5, 2025 14:44

Maymanaf reviewed Feb 5, 2025

View reviewed changes

front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved

front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved

front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch 9 times, most recently from aeb53be to 667ae81 Compare February 6, 2025 13:49

Maymanaf approved these changes Feb 6, 2025

View reviewed changes

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 5750b14 to 8317bd9 Compare February 6, 2025 17:45

Caracol3 added this pull request to the merge queue Feb 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025

Caracol3 added this pull request to the merge queue Feb 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 8317bd9 to 8477d02 Compare February 7, 2025 15:46

lmr: putting ma100 as default value only for lmr

1a2ec20

- nospeedlimittag is only displayed in debugmode in stdcm - adapt stdcm tests to be coherent with the default composition code Signed-off-by: Mathieu <[email protected]>

Caracol3 force-pushed the mcy/front-lmr-composition-code-with-mandatory-ma100 branch from 8477d02 to 1a2ec20 Compare February 10, 2025 06:34

Caracol3 added this pull request to the merge queue Feb 10, 2025

Merged via the queue into dev with commit 1a2ec20 Feb 10, 2025
53 checks passed

Caracol3 deleted the mcy/front-lmr-composition-code-with-mandatory-ma100 branch February 10, 2025 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lmr: putting ma100 as default value in the speedlimittag selector #9987

lmr: putting ma100 as default value in the speedlimittag selector #9987

Caracol3 commented Dec 9, 2024 •

edited

Loading

codecov-commenter commented Dec 9, 2024 •

edited

Loading

Akctarus left a comment •

edited

Loading

Yohh left a comment

clarani left a comment

Maymanaf left a comment

lmr: putting ma100 as default value in the speedlimittag selector #9987

lmr: putting ma100 as default value in the speedlimittag selector #9987

Conversation

Caracol3 commented Dec 9, 2024 • edited Loading

codecov-commenter commented Dec 9, 2024 • edited Loading

Codecov Report

Akctarus left a comment • edited Loading

Choose a reason for hiding this comment

Yohh left a comment

Choose a reason for hiding this comment

clarani left a comment

Choose a reason for hiding this comment

Maymanaf left a comment

Choose a reason for hiding this comment

Caracol3 commented Dec 9, 2024 •

edited

Loading

codecov-commenter commented Dec 9, 2024 •

edited

Loading

Akctarus left a comment •

edited

Loading