-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a limit of collected items #2051
Merged
Merged
Commits on Nov 13, 2023
-
This commit extracts the code that marks the item produced by probe as incomplete to a static function _mark_collected_object_as_incomplete so that it can be reused in other code later
Configuration menu - View commit details
-
Copy full SHA for d1045b2 - Browse repository at this point
Copy the full SHA d1045b2View commit details
Commits on Nov 14, 2023
-
Introduce a limit for collected objects
If a single OVAL object matches more than 10000 items, we will stop collecting these items and mark the object as incomplete. This should prevent some situations in which the produced results are too large and cause memory problems or inability to generate the HTML report.
Configuration menu - View commit details
-
Copy full SHA for b20fca6 - Browse repository at this point
Copy the full SHA b20fca6View commit details -
This commit adds a simple test that covers a situation when the probe collects more items than the limit for a single OVAL object.
Configuration menu - View commit details
-
Copy full SHA for 5e3d8bc - Browse repository at this point
Copy the full SHA 5e3d8bcView commit details -
Handle return value of probe_item_collect
The `probe_item_collect` function can fail and it can return various return codes. But, the return codes aren't handled in the caller function `process_file`. That means the `process_file` continues to process items even if no other items can be collected due to memory constraints or other problems. With this commit, we will read the return code of `probe_item_collect` and react accordingly.
Configuration menu - View commit details
-
Copy full SHA for 176f1a8 - Browse repository at this point
Copy the full SHA 176f1a8View commit details
Commits on Nov 21, 2023
-
Make probe items limit configurable
Users can limit the amount of items collected by setting the `OSCAP_PROBE_MAX_COLLECTED_ITEMS` environment variable. By default, the amount of items is unlimited.
Configuration menu - View commit details
-
Copy full SHA for f2461c7 - Browse repository at this point
Copy the full SHA f2461c7View commit details
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fb97a51 - Browse repository at this point
Copy the full SHA fb97a51View commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dd1977c - Browse repository at this point
Copy the full SHA dd1977cView commit details -
Rename "memory" directory to "probe_behavior"
The behavior alteration we are testing here is not exactly connected to memory. I'd rather name it like probe_behavior to make the folder a collection of tests related to these env. vars.
Configuration menu - View commit details
-
Copy full SHA for 6b29c04 - Browse repository at this point
Copy the full SHA 6b29c04View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.