Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/817 - workspace folder icon callback + fix public workspace in my accounts #853

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Feature/817 - workspace folder icon callback + fix public workspace in my accounts #853

merged 3 commits into from
Dec 21, 2023

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Dec 18, 2023 •
edited
Loading

Task description:
Closes: #817
This PR fixes two things:

  1. Workspace icon in my accounts - callback - so that it is clickable - 817
  2. Fix the public workspace my accounts tab. Previously it showed all the public workspace after the refactor. This fixes that bug. Following is the video description for the same implementation.
2023-12-18.14-58-17.mp4

filippomc
filippomc approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@filippomc filippomc merged commit eca2dc0 into develop Dec 21, 2023
3 checks passed
@filippomc filippomc deleted the feature/817 branch December 21, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D-GopalKrishna @filippomc