Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling PWS with local persistence #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruimarinho
Copy link

If a PWS (Personal Weather Station) is configured (currently, only the WU type is recognized by the code), OpenSprinkler-Weather will automatically register the route /weatherstation/updateweatherstation.php to capture the WU data stream.

However, it only saves changes from the captured stream if the WEATHER_PROVIDER is set to local. In my opinion, this is too restrictive, as one might want to collect observations before switching to the local weather provider.

Therefore, I suggest testing for the presence of the PWS variable instead, allowing the capturing system to function fully without requiring a provider switch.

@mellodev
Copy link

mellodev commented Jan 28, 2025

@rayshobby we should review if this can be closed/integrated when the recent weather related changes are complete cc @Ncp294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants