Fix package entrypoint #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to be used using require() and npm.
jupe
requested changes
Apr 28, 2021
| @@ -28,12 +28,12 @@ class Ykush { | |||
| } | |||
|
|
|||
| async powerAllOn() { | |||
| const args = [...this._prefix, '-s', this._serialNumber, '-u', 'a']; | |||
| const args = [...this._prefix, '-s', this._serialNumber.id, '-u', 'a']; | |||
There was a problem hiding this comment.
This should be fixed in otherway and separate PR. list() function should return list of serialnumber instead of list of objects with id field.
| @@ -12,6 +12,7 @@ | |||
| "type": "git", | |||
| "url": "git+https://github.com/opentmi/ykushjs.git" | |||
| }, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the package to be used using require() and npm.
This will allow the package to be used with
npm install. It will also need to be republished to the npm registry.