Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change UnknownScannerException to NonRecoverableException #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change UnknownScannerException to NonRecoverableException #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/RegionClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,6 +1547,7 @@ protected Object decode(final ChannelHandlerContext ctx,
final class RetryTimer implements TimerTask {
public void run(final Timeout timeout) {
if (isAlive()) {
rpc.attempt++;
sendRpc(rpc);
} else {
if (rpc instanceof MultiAction) {
Expand Down
2 changes: 1 addition & 1 deletion src/UnknownScannerException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/**
* Exception thrown when we try to use an invalid or expired scanner ID.
*/
public final class UnknownScannerException extends RecoverableException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require some more work as the scanner would need to be reopened with a new UID. What does it solve for you?

public final class UnknownScannerException extends NonRecoverableException
implements HasFailedRpcException {

static final String REMOTE_CLASS =
Expand Down