Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate plugin threads after deserialiser #11

Merged
merged 2 commits into from
Dec 28, 2018

Conversation

muffix
Copy link
Contributor

@muffix muffix commented Dec 3, 2018

This moves the instantiation of the plugin thread objects after the
creation of the deserialiser. Previously, the threads were trying to
access the deserialiser which wasn't initialised yet and were trying to
work with a null pointer.

Resolves: #10

This moves the instantiation of the plugin thread objects after the
creation of the deserialiser. Previously, the threads were trying to
access the deserialiser which wasn't initialised yet and were trying to
work with a null pointer.

Resolves: OpenTSDB#10
@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage remained the same at 51.888% when pulling 5db778e on muffix:delay-thread-creation into ebaa8af on OpenTSDB:master.

Config entries are case sensitive and the readme previously incorrectly
capitalised "Deserializer".
@manolama manolama merged commit 5c1a70f into OpenTSDB:master Dec 28, 2018
@muffix muffix deleted the delay-thread-creation branch December 29, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants