Improve inventory cleanup on the first time setup workflow

[Ndpnt]

Add cleaning of encrypted values

[MattiSG]

Good catch!
But, just like we forgot to update this workflow file when we updated the inventory, we will again forget to update it on the next change 😕
Could we maybe keep that default file alongside the actual inventory? Or at least as a file alongside the workflow in the .github folder?

[Ndpnt]

Could we maybe keep that default file alongside the actual inventory? Or at least as a file alongside the workflow in the .github folder?

In my opinion, this solution does not provide any additional visibility to the default inventory.

Could we maybe keep that default file alongside the actual inventory?

This one seems to be a better idea.
But after trying locally, my opinion is that this solution will pollute the demo repository, which will start to look more like a template than a demo repository, and that's what we wanted to avoid when we decided to merge demo and template repositories. I also think this raises the question of doing the same for the README and for config/production.json.

Finally, I'm not really convinced that this will prevent us from forgetting to update it.

I prefer to live with the current situation, and I think it's our responsibility to bear in mind that this repository is not a collection like any other, but that it also serves as a template.

[MattiSG]

Okay, you convinced me. I am sure we will forget again, but I agree this is a risk more worth taking than polluting the demo 👍