Provide a dedicated route in the Version API to obtain the latest version of some terms #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
requested changes
Dec 12, 2023
There was a problem hiding this comment.
I like the refactor of tests and the opening of this route, but it is missing some important design choices. In particular, what happens if a service has been terminated, or if the chosen terms types have been phased out by the service? The latest version exists, but is not valid anymore. Do we really want to expose latest, or do we want to expose the current version?
If the service has been terminated (or the terms types do not exist anymore), do we reply with 404, 416 or 410 Gone?
Those questions should be discussed in a separate place than the PR implementing it.
| @@ -97,14 +148,18 @@ router.get('/version/:serviceId/:termsType/:date', async (req, res) => { | |||
| const version = await versionsRepository.findByDate(serviceId, termsType, requestedDate); | |||
|
|
|||
| if (!version) { | |||
| return res.status(404).json({ error: `No version found for date ${date}` }); | |||
| return res.status(404).json({ error: `No version found the specified combination of service ID "${serviceId}", terms type "${termsType}" and date ${date}` }); | |||
There was a problem hiding this comment.
Suggested change
| return res.status(404).json({ error: `No version found the specified combination of service ID "${serviceId}", terms type "${termsType}" and date ${date}` }); | |
| return res.status(404).json({ error: `No version found for the specified combination of service ID "${serviceId}", terms type "${termsType}" and date ${date}` }); |
|
Close this long-lived PR as it is not a priority right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.