-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include contributing section in Readme #1040
Conversation
As this is an internal change, I do not believe the changelog modification is necessary. How could I pass the CI without changing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @jetlime.
I've got a few suggestions to enhance it, including adjustments to align with our contributing guidelines 😉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you @jetlime for this contribution and for having observed so well the changelog format! 👏 we definitely ought to clarify the cases with documentation-only changes and how they impact the release process.
Thank you once more for your contribution and sorry for the initial delay of response. As there are a lots of changes to deal with, we'll take care of it. |
Co-authored-by: Matti Schneider <[email protected]>
Fixes: #1038