Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contributing section in Readme #1040

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Include contributing section in Readme #1040

merged 4 commits into from
Feb 12, 2024

Conversation

jetlime
Copy link
Contributor

@jetlime jetlime commented Jan 4, 2024

Fixes: #1038

@jetlime
Copy link
Contributor Author

jetlime commented Jan 4, 2024

As this is an internal change, I do not believe the changelog modification is necessary. How could I pass the CI without changing it?

Copy link
Member

@Ndpnt Ndpnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jetlime.
I've got a few suggestions to enhance it, including adjustments to align with our contributing guidelines 😉.

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you @jetlime for this contribution and for having observed so well the changelog format! 👏 we definitely ought to clarify the cases with documentation-only changes and how they impact the release process.

@Ndpnt
Copy link
Member

Ndpnt commented Feb 12, 2024

Thank you once more for your contribution and sorry for the initial delay of response. As there are a lots of changes to deal with, we'll take care of it.

@Ndpnt Ndpnt merged commit d3d33b5 into OpenTermsArchive:main Feb 12, 2024
7 checks passed
@jetlime jetlime deleted the contributing-readme branch February 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link CONTRIBUTING file from README
3 participants