Ease listing contributors #277
Conversation
✅ Deploy Preview for open-terms-archive-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
clementbiron
force-pushed
the
ease-listing-contributors
branch
from
0cc3b21 to
8280236
Compare
There was a problem hiding this comment.
Thanks! It's probably worth having a quick chat regarding the CONTRIBUTING file 🙂
I'd also be happy for 10 minutes reviewing together the contribution types assigned to each contributor. It's not super important, but if we do add types, let's try to make them right 😉
| "avatar_url": "https://avatars.githubusercontent.com/u/765477?v=4", | ||
| "profile": "https://github.com/avernois", | ||
| "contributions": [ | ||
| "code" |
There was a problem hiding this comment.
It was more mentoring / technical coaching.
| "avatar_url": "https://avatars.githubusercontent.com/u/82889095?v=4", | ||
| "profile": "https://github.com/AaronjSugarman", | ||
| "contributions": [ | ||
| "code" |
There was a problem hiding this comment.
Since we have categories, I'd like us to distinguish “code” from declarations 🙂
| "avatar_url": "https://avatars.githubusercontent.com/u/46820105?v=4", | ||
| "profile": "https://github.com/mvidonne", | ||
| "contributions": [ | ||
| "data", |
There was a problem hiding this comment.
Is “data” used to distinguish contributions, or data analysis?
| "avatar_url": "https://avatars.githubusercontent.com/u/41912392?v=4", | ||
| "profile": "https://github.com/AdrienFines", | ||
| "contributions": [ | ||
| "code" |
| ### How to add a type of contribution to a contributor | ||
|
|
||
| You can do this by editing the `.all-contributorsrc` file or by using the bot with `@all-contributors please add @<already_listed_contributor> for <new_contribution_type>` |
There was a problem hiding this comment.
There is no explanation in the CONTRIBUTING that a “contributor” needs to have a “contribution type”, nor a reference of which ones we use and the interpretation we give to it 🙂
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "files": [ | |||
| "README.md" | |||
| ".all-contributors.md" | |||
There was a problem hiding this comment.
I tried and it doesn't work: Error: ENOENT: no such file or directory
Co-authored-by: Matti Schneider <[email protected]>
I deliberately didn't go into too much detail because a link to the All Contributors documentation and a command exemple seemed sufficient to me.
Hopefully we won't need to explain how we use them, they'll just speak for themselves. But let's look at it in sync. |
|
After discussion: maybe just clarify that we use |
That changeset uses the
all-contributorsrcfile as a data source for contributors list on the website and adds astaff.jsonto display the different team members.It's not easy to choose one or more types of contribution per contributor, and it's mandatory. I've made an initial proposal that can be improved, but I wanted to deliver it as quickly as possible. If you want to make suggestions, use the documentation on this subject.