Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reuse Lab-LEX report #285

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Add reuse Lab-LEX report #285

merged 6 commits into from
Dec 8, 2023

Conversation

clementbiron
Copy link
Member

No description provided.

@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for open-terms-archive-website ready!

Name Link
🔨 Latest commit e249db5
🔍 Latest deploy log https://app.netlify.com/sites/open-terms-archive-website/deploys/65734cba8062ca00091911a4
😎 Deploy Preview https://deploy-preview-285--open-terms-archive-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clementbiron clementbiron force-pushed the add-reuse-report-lab-lex branch from 77889d5 to 76cb4cb Compare December 8, 2023 10:03
@clementbiron clementbiron requested a review from MattiSG December 8, 2023 10:07
MattiSG
MattiSG requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe the suggested titles and illustrations are too broad and made some suggestions 🙂

locales/en/homepage.json Outdated Show resolved Hide resolved
locales/en/homepage.json Outdated Show resolved Hide resolved
locales/en/homepage.json Outdated Show resolved Hide resolved
public/images/reuses/report-lab-lex-en.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had in mind to use the bright color cover, as it is more recognisable and graphically more pleasing. Most of our reuses images are already text excerpts.

image

If possible, an assemblage with the affiliation logos would be very welcome:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I did first ^^ but I changed for the current thumbnail to harmonise the rendering and because it requires some CSS adaptations to not crop the text on the image.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that one so much!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please please please can we have that one? 🙏

@clementbiron @MattiSG
Improve wording
4953af1 
Co-authored-by: Matti Schneider <[email protected]>
@clementbiron clementbiron requested a review from MattiSG December 8, 2023 16:34
MattiSG
MattiSG requested changes Dec 8, 2023
View reviewed changes
locales/fr/homepage.json Outdated Show resolved Hide resolved
MattiSG
MattiSG approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping for the nice orange illustration 🤞 😉

@MattiSG
Copy link
Member

MattiSG commented Dec 8, 2023

Please drop a line in ~Reuses with a mention to the authors when it's done, they'll be happy 😊

@clementbiron clementbiron merged commit 7367488 into main Dec 8, 2023
7 checks passed
@clementbiron clementbiron deleted the add-reuse-report-lab-lex branch December 8, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementbiron @MattiSG