unittests/fallback_service

.github/workflows/coverage.yml

@@ -27,7 +27,6 @@ jobs:
     - name: Install test dependencies
       run: |
         pip install -r requirements/tests.txt
-        pip install git+https://github.com/OpenVoiceOS/OVOS-workshop@fallback/no_make_active
         pip install ./test/unittests/common_query/ovos_tskill_fakewiki
         pip install ./test/end2end/session/skill-ovos-hello-world
         pip install ./test/end2end/session/skill-ovos-fallback-unknown

.github/workflows/unit_tests.yml

@@ -54,7 +54,6 @@ jobs:
       - name: Install test dependencies
         run: |
           pip install -r requirements/tests.txt
-          pip install git+https://github.com/OpenVoiceOS/OVOS-workshop@fallback/no_make_active
           pip install ./test/unittests/common_query/ovos_tskill_fakewiki
           pip install ./test/end2end/session/skill-ovos-hello-world
           pip install ./test/end2end/session/skill-ovos-fallback-unknown

requirements/requirements.txt

@@ -12,7 +12,7 @@ ovos-plugin-manager<0.1.0, >=0.0.24a9
 ovos-config~=0.0,>=0.0.11a13
 ovos-lingua-franca>=0.4.7
 ovos-backend-client>=0.1.0a12
-ovos-workshop<0.1.0, >=0.0.13a5
+ovos-workshop<0.1.0, >=0.0.13a6
 
 # provides plugins and classic machine learning framework
 ovos-classifiers<0.1.0, >=0.0.0a37

test/end2end/session/skill-ovos-fallback-unknown/__init__.py

@@ -6,18 +6,5 @@ class UnknownSkill(FallbackSkill):
 
     @fallback_handler(priority=100)
     def handle_fallback(self, message):
-        utterance = message.data['utterance'].lower()
-
-        try:
-            self.report_metric('failed-intent', {'utterance': utterance})
-        except Exception:
-            self.log.exception('Error reporting metric')
-
-        for i in ['question', 'who.is', 'why.is']:
-            if self.voc_match(utterance, i):
-                self.log.debug('Fallback type: ' + i)
-                self.speak_dialog(i)
-                break
-        else:
-            self.speak_dialog('unknown')
+        self.speak_dialog('unknown')
         return True