feat/pipeline #336
Merged
feat/pipeline #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #336 +/- ##
==========================================
- Coverage 50.35% 49.41% -0.94%
==========================================
Files 119 12 -107
Lines 10077 1623 -8454
==========================================
- Hits 5074 802 -4272
+ Misses 5003 821 -4182 |
JarbasAl
commented
Jul 14, 2023
| @@ -199,6 +223,38 @@ def disambiguate_lang(message): | |||
|
|
|||
| return default_lang | |||
|
|
|||
| def get_pipeline(self, skip_converse=False, skip_fallback=False): | |||
| # Create matchers | |||
| # TODO - from plugins | |||
There was a problem hiding this comment.
will solve this TODO in #310
for now just want to make it configurable to clean up padatious/padacioso and allow more control for users
JarbasAl
added a commit
to OpenVoiceOS/ovos-config
that referenced
this pull request
Aug 7, 2023
- pipeline settings from OpenVoiceOS/ovos-core#336 - default to padatious again - homescreen enabled by default in GUI - mycroft-gui added to native sources (audio)
forslund
reviewed
Aug 7, 2023
|
relevant docs in default config here https://github.com/OpenVoiceOS/ovos-config/pull/63/files#diff-97d1dc6bf78002315ed82919af2d2f7438d7c6fb07f6fff7b8df14026582a93bR123 |
JarbasAl
commented
Aug 7, 2023
| @@ -6,13 +6,13 @@ combo-lock>=0.2.2, <0.3 | |||
| padacioso~=0.2, >=0.2.1a8 | |||
| adapt-parser>=1.0.0, <2.0.0 | |||
|
|
|||
| ovos_bus_client<0.1.0, >=0.0.5 | |||
| ovos_bus_client<0.0.6a1, >=0.0.5 | |||
There was a problem hiding this comment.
TODO OpenVoiceOS/ovos-bus-client@6eb7c56 introduced some issue where unittests hang forever test/unittests/skills/test_event_container.py .... [ 34%]
This was referenced Sep 20, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurable intent stage