Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests/explicit_session + fix/codecov workflow #356

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 30, 2023

unitests/test_explicit_session

maybe fix codecov workflow

@JarbasAl JarbasAl added the tests and automation added unittests or github workflows label Sep 30, 2023
@JarbasAl JarbasAl mentioned this pull request Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6ceb058) 50.35% compared to head (cab4f2b) 45.69%.
Report is 420 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #356      +/-   ##
==========================================
- Coverage   50.35%   45.69%   -4.67%     
==========================================
  Files         119       13     -106     
  Lines       10077     1845    -8232     
==========================================
- Hits         5074      843    -4231     
+ Misses       5003     1002    -4001     

see 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review September 30, 2023 06:00
@JarbasAl JarbasAl changed the title add more tests add more tests / fix codecov workflow Sep 30, 2023
@JarbasAl JarbasAl merged commit f015522 into dev Sep 30, 2023
4 of 5 checks passed
@JarbasAl JarbasAl deleted the unitests/sessions branch September 30, 2023 06:04
@JarbasAl JarbasAl added this to the 0.0.8 milestone Sep 30, 2023
@JarbasAl JarbasAl changed the title add more tests / fix codecov workflow unittests/explicit_session + fix/codecov workflow Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests and automation added unittests or github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant