Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mycroft #439

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

remove mycroft #439

wants to merge 2 commits into from

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 8, 2024

mycroft is dead

we can keep any wanted pieces alive as long as needed under https://github.com/OpenVoiceOS/mycroft-legacy

closes #438

needs OpenVoiceOS/OVOS-workshop#235

@JarbasAl JarbasAl added refactor code refactor without functional changes breaking breaks backwards compatibility (kinda) labels Apr 8, 2024
@JarbasAl JarbasAl added this to the 0.1.0 milestone Apr 8, 2024
@JarbasAl JarbasAl requested review from j1nx, NeonDaniel and a team April 8, 2024 03:42
@JarbasAl JarbasAl marked this pull request as draft July 22, 2024 17:42
Copy link

coderabbitai bot commented Sep 18, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

214 files out of 296 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl
Copy link
Member Author

@coderabbitai review

Copy link

coderabbitai bot commented Sep 18, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (23f0bab) to head (8e9406c).
Report is 39 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #439      +/-   ##
==========================================
- Coverage   75.33%   69.60%   -5.74%     
==========================================
  Files          15       15              
  Lines        3094     1859    -1235     
==========================================
- Hits         2331     1294    -1037     
+ Misses        763      565     -198     
Flag Coverage Δ
unittests 51.52% <ø> (-23.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added this to the 2.0.0 milestone Oct 15, 2024
@JarbasAl JarbasAl marked this pull request as ready for review October 15, 2024 17:36
@JarbasAl
Copy link
Member Author

end2end tests seem to be hanging forever in the fallback step, need to investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaks backwards compatibility (kinda) refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove mycroft namespace compatibility imports
2 participants