fix:no wait for ready

[JarbasAl]

dont wait for mycroft.ready message, display homescreen ASAP

Summary by CodeRabbit

• New Features

  • Simplified homescreen display logic, allowing the homescreen to show immediately upon initialization without waiting for Mycroft readiness.

• Bug Fixes

  • Removed outdated checks related to Mycroft's readiness state, streamlining the homescreen management process.

• Tests

  • Updated unit tests by removing tests related to the Mycroft readiness state, reflecting the changes in homescreen logic.

[coderabbitai]

Caution

Review failed

The head commit changed during the review from d8c6eb1 to cf26d44.

Walkthrough

The changes involve modifications to the HomescreenManager class in ovos_gui/homescreen.py, specifically removing the mycroft_ready attribute and its associated logic. The show_homescreen_on_add method no longer checks for Mycroft's readiness, allowing the homescreen to display immediately upon initialization. Additionally, the set_mycroft_ready method has been removed, simplifying the homescreen management process. Correspondingly, the TestHomescreenManager class in test/unittests/test_homescreen.py has been updated to reflect these changes, including the removal of tests related to the mycroft_ready attribute.

Changes

File	Change Summary
ovos_gui/homescreen.py	Removed mycroft_ready attribute and set_mycroft_ready method; updated homescreen display logic.
test/unittests/test_homescreen.py	Removed test_set_mycroft_ready method and related assertions for mycroft_ready.

Possibly related PRs

• fix:handle unloaded namespaces #51: The changes in the main PR involve the removal of the mycroft_ready attribute and associated logic in the HomescreenManager, which may relate to the control flow adjustments made in the Namespace class in PR fix:handle unloaded namespaces #51, as both PRs modify how the system handles state and readiness in the GUI context.

Suggested labels

fix

Suggested reviewers

• j1nx

Poem

🐰 In the burrow where screens do glow,
The homescreen now will freely show.
No more waiting for Mycroft's cue,
Just hop right in, there's much to do!
With simpler paths, we leap with glee,
A joyful home for you and me! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JarbasAl]

this only reason this was there was to allow setup skill (pairing) to handle the screen before this stage, but that skill has been deprecated for a long time

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

ovos_gui/homescreen.py (1)

Issue Identified: The set_mycroft_ready method is still being called in ovos_gui/service.py but its definition has been removed.

• ovos_gui/service.py: self.extension_manager.homescreen_manager.set_mycroft_ready(resp)

🔗 Analysis chain

Line range hint 1-93: Verify Removal of mycroft_ready References in Codebase

With the removal of the mycroft_ready attribute and its associated logic, please verify that there are no remaining references to mycroft_ready in the codebase that might cause errors or unintended behavior.

Run the following script to confirm:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any remaining references to `mycroft_ready` in the codebase.

# Test: Find any occurrences of `mycroft_ready` in Python files.
rg 'mycroft_ready' --glob '*.py'

Length of output: 130

---

Script:

#!/bin/bash
# Description: Find the definition and usage of `set_mycroft_ready` in the codebase.

rg 'def set_mycroft_ready' --glob '*.py'

Length of output: 42

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 479164c and ed1dabf.

📒 Files selected for processing (2)

• ovos_gui/homescreen.py (1 hunks)
• test/unittests/test_homescreen.py (0 hunks)

💤 Files with no reviewable changes (1)

• test/unittests/test_homescreen.py

🧰 Additional context used

🔇 Additional comments (1)

ovos_gui/homescreen.py (1)

30-30: Ensuring Immediate Homescreen Display Upon Startup

The addition of self.show_homescreen() in the run method ensures that the homescreen is displayed immediately when the HomescreenManager thread starts, aligning with the PR objective to display the homescreen without waiting for Mycroft readiness.