Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:missing messages to forward #74

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix:missing messages to forward #74

merged 1 commit into from
Jan 7, 2025

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jan 7, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced GUI communication by adding new message types for:
      • Utterance handling events
      • Skill execution tracking
      • Intent processing notifications

Copy link
Contributor

coderabbitai bot commented Jan 7, 2025

Walkthrough

The changes involve expanding the message forwarding capabilities in the NamespaceManager class within the ovos_gui/namespace.py file. Six new message types are added to the list of messages that can be forwarded to GUI clients, enhancing the communication between the core system and the graphical interface. These new messages cover various events related to utterance handling, skill execution, and intent processing, providing more comprehensive event tracking and communication.

Changes

File Change Summary
ovos_gui/namespace.py Added 6 new message types to messages_to_forward:
- "ovos.utterance.handled"
- "ovos.utterance.cancelled"
- "mycroft.skill.handler.start"
- "mycroft.skill.handler.complete"
- "complete_intent_failure"
- "recognizer_loop:utterance"

Poem

🐰 Hop, hop, messages fly so bright,
New events dancing in the light!
From utterance to skill's sweet song,
GUI now knows where it belongs
Communication leaps along! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added fix and removed fix labels Jan 7, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
ovos_gui/namespace.py (1)

464-469: LGTM! Enhanced event forwarding for utterance and skill handling.

The addition of these core event messages improves the GUI's ability to track and respond to utterance handling and skill execution states.

Consider grouping related messages under descriptive comments for better code organization, similar to how audio and speech service messages are grouped.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ff2777 and e9fa90e.

📒 Files selected for processing (1)
  • ovos_gui/namespace.py (1 hunks)
🔇 Additional comments (2)
ovos_gui/namespace.py (2)

478-478: LGTM! Added utterance event forwarding.

The addition of "recognizer_loop:utterance" event complements the other recognizer loop events already being forwarded.


464-478: Verify event handling on the GUI side.

The new events being forwarded should have corresponding handlers in the GUI clients to properly display or react to these events.

Let's verify the GUI clients are prepared to handle these new events:

@JarbasAl JarbasAl merged commit d617970 into dev Jan 7, 2025
6 of 12 checks passed
@JarbasAl JarbasAl deleted the msg branch January 7, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant