-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:missing messages to forward #74
Conversation
WalkthroughThe changes involve expanding the message forwarding capabilities in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ovos_gui/namespace.py (1)
464-469
: LGTM! Enhanced event forwarding for utterance and skill handling.The addition of these core event messages improves the GUI's ability to track and respond to utterance handling and skill execution states.
Consider grouping related messages under descriptive comments for better code organization, similar to how audio and speech service messages are grouped.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ovos_gui/namespace.py
(1 hunks)
🔇 Additional comments (2)
ovos_gui/namespace.py (2)
478-478
: LGTM! Added utterance event forwarding.The addition of "recognizer_loop:utterance" event complements the other recognizer loop events already being forwarded.
464-478
: Verify event handling on the GUI side.The new events being forwarded should have corresponding handlers in the GUI clients to properly display or react to these events.
Let's verify the GUI clients are prepared to handle these new events:
Summary by CodeRabbit