Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand DE yes no alternatives #66

Merged
merged 2 commits into from
Jun 20, 2024
Merged

expand DE yes no alternatives #66

merged 2 commits into from
Jun 20, 2024

Conversation

emphasize
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@a92f9a0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #66   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      69           
  Lines          ?   18387           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?   18387           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emphasize
Copy link
Member Author

Have to sleep over it, maybe rearrange (esp. bc those double negatives) and add some Tests

@JarbasAl
Copy link
Member

Have to sleep over it, maybe rearrange (esp. bc those double negatives) and add some Tests

please add tests for the use cases this is covering, being your native language you are the authority, we can only review tests and trust you on the language side

@JarbasAl JarbasAl added the enhancement New feature or request label Aug 30, 2023
@emphasize
Copy link
Member Author

generally hard to compute sarcasm/irony.
additionally we usually prefix like "not impossible" (ie. un-*)
The question should be clear cut on the skill side

@emphasize
Copy link
Member Author

emphasize commented Aug 31, 2023

Maybe we should allow a dict to be passed and merged with the default, so we can assure better contextual accuracy.
We could use the data that is already part of the signature

@JarbasAl JarbasAl requested review from ChanceNCounter and a team September 13, 2023 18:43
@JarbasAl JarbasAl merged commit 6a13ca5 into dev Jun 20, 2024
@JarbasAl JarbasAl deleted the add/de_yesno branch June 20, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants