Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated incorrect skill.json #21

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

suvanbanerjee
Copy link

the skill.json file in skill-ovos-hello is of skill-ovos-date-time this PR fixes it :)

@suvanbanerjee
Copy link
Author

suvanbanerjee commented May 6, 2024

@goldyfruit I think the skill.json file has to present in the root dir of skill ? should i add a commit to make a copy of skill.json in root dir also

@JarbasAl
Copy link
Member

JarbasAl commented May 6, 2024

these files are old proof of concepts and were never formally adopted (they came from bigscreen, not mycroft or OVOS)

the current specification can be found here https://openvoiceos.github.io/ovos-technical-manual/skill_json/

these files should now go into the locale/lang-code folders like all other files, the contents also changed slightly

@suvanbanerjee
Copy link
Author

@JarbasAl thanks! the technical manual slipped from my mind. I will make the necessary changes. and for the time being I will make this pr as draft

@suvanbanerjee suvanbanerjee marked this pull request as draft May 6, 2024 17:07
@suvanbanerjee suvanbanerjee marked this pull request as ready for review May 8, 2024 15:36
locale/en-us/skill.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants