Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grape Varities Json #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Grape Varities Json #4

wants to merge 2 commits into from

Conversation

kentux
Copy link

@kentux kentux commented May 15, 2015

Hey,

J'ai fait une extraction depuis la page Wikipedia : https://en.wikipedia.org/wiki/List_of_grape_varieties

A voir pour le contenu, ça peu servir de base de discussion.

@ronanguilloux
Copy link
Member

Hey @kentux, nice PR!

  • is there any grape variety that actually uses the OtherNames field? I didn't find any so far (but I just made a quick look)
  • could you cite the origin/sources of the data?
  • are you OK to join an ODbL license to this dataset? (we'll check your source first)
  • could you add these informations inside a simple README.md text file aside this one please?

Thanks!

@kentux
Copy link
Author

kentux commented May 15, 2015

Thanks !

  • OtherNames isn't used for the moment : I have no idea to populate this field easily...
    • Aroma too : I Think it's easier to add this data
    • Description : like others... I think this field should be filled manualy
  • No problem to use ODbL license
  • I will add source and license in the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants