Support needUpdate and defaultUpdate for DifftestBaseBundle #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The valid bits are actually defined in the base bundle. Thus, we move them from DifftestBundle to DifftestBaseBundle.
poemonsense
force-pushed
the
fix-update
branch
from
9262bc1 to
abc4465
Compare
pxk27
pushed a commit
to pxk27/difftest
that referenced
this pull request
Jan 30, 2024
…gShan#262) The valid bits are actually defined in the base bundle. Thus, we move them from DifftestBundle to DifftestBaseBundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid bits are actually defined in the base bundle. Thus, we move them from DifftestBundle to DifftestBaseBundle.