Minor improvements to Account package #1224
Open
+109
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 92.06% 92.02% -0.04%
==========================================
Files 49 49
Lines 1399 1392 -7
==========================================
- Hits 1288 1281 -7
Misses 111 111
Continue to review full report in Codecov by Sentry.
|
ericnordelo
approved these changes
Nov 19, 2024
| } else { | ||
| assert(MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION); | ||
| } | ||
| assert(is_tx_version_valid(), Errors::INVALID_TX_VERSION); |
andrew-fleming
approved these changes
Nov 19, 2024
Comment on lines
-79
to
+76
| // Check tx version | ||
| let tx_info = get_tx_info().unbox(); | ||
| let tx_version: u256 = tx_info.version.into(); | ||
| // Check if tx is a query | ||
| if (tx_version >= QUERY_OFFSET) { | ||
| assert( | ||
| QUERY_OFFSET + MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION | ||
| ); | ||
| } else { | ||
| assert(MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION); | ||
| } | ||
| assert(is_tx_version_valid(), Errors::INVALID_TX_VERSION); |
| pub fn execute_calls(mut calls: Span<Call>) -> Array<Span<felt252>> { | ||
| pub fn execute_calls(calls: Span<Call>) -> Array<Span<felt252>> { |
There was a problem hiding this comment.
Should we list this under Changed (not breaking) in the changelog?
There was a problem hiding this comment.
If so, same with __execute__
Comment on lines
+25
to
+33
| /// If the transaction is a simulation (version >= `QUERY_OFFSET`), it must be | ||
| /// greater than or equal to `QUERY_OFFSET` + `MIN_TRANSACTION_VERSION` to be considered valid. | ||
| /// Otherwise, it must be greater than or equal to `MIN_TRANSACTION_VERSION`. | ||
| pub fn is_tx_version_valid() -> bool { | ||
| let tx_info = starknet::get_tx_info().unbox(); | ||
| let tx_version = tx_info.version.into(); | ||
| if tx_version >= QUERY_OFFSET { | ||
| QUERY_OFFSET + MIN_TRANSACTION_VERSION <= tx_version | ||
| } else { |
There was a problem hiding this comment.
I'd add this to the changelog as well since it's pub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist