Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cairo to v0.20.0 #419

Merged

Conversation

andrew-fleming
Copy link
Contributor

Compiles as expected locally

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you also bump the version in packages/core-cairo/package.json?

Copy link

socket-security bot commented Dec 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rollup/[email protected] None 0 20.9 kB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] filesystem +1 268 kB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 10.7 kB shellscape
npm/@rollup/[email protected] None +2 195 kB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 26.4 kB shellscape
npm/@rollup/[email protected] environment, filesystem 0 134 kB shellscape
npm/@types/[email protected] None 0 6.31 kB types
npm/@types/[email protected] None 0 5.45 kB types
npm/@types/[email protected] None 0 7.92 kB types
npm/@types/[email protected] None 0 4.02 kB types
npm/@types/[email protected] None +1 2.1 MB types
npm/@types/[email protected] None 0 5.44 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/@types/[email protected] None 0 8.65 kB types
npm/@types/[email protected] None 0 50.4 kB types
npm/[email protected] None 0 5.17 kB qix
npm/[email protected] Transitive: eval +78 4.06 MB ljharb
npm/[email protected] Transitive: eval +78 4.06 MB ljharb
npm/[email protected] environment Transitive: filesystem +4 2.65 MB ai
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +159 10.9 MB novemberborn
npm/[email protected] environment, eval, unsafe 0 632 kB esailija
npm/[email protected] None 0 7.45 kB sindresorhus
npm/[email protected] None +1 18.8 kB bcoe
npm/[email protected] environment, filesystem, shell 0 18.3 kB satazor
npm/[email protected] None 0 2.94 kB sindresorhus
npm/[email protected] None 0 36.3 kB mathias
npm/[email protected] None 0 6.23 kB mafintosh
npm/[email protected] None +6 3.8 MB paulmillr
npm/[email protected] environment, shell 0 19.9 kB sindresorhus
npm/[email protected] None 0 36 kB endless
npm/[email protected] None 0 4.84 kB sindresorhus
npm/[email protected] None 0 7.88 kB sindresorhus
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +203 172 MB alcuadrado, fvictorio, fzeoli, ...3 more
npm/[email protected] None 0 3.23 kB sindresorhus
npm/[email protected] environment +1 27.3 kB scotthovestadt
npm/[email protected] Transitive: environment +11 1.79 MB stuk
npm/[email protected] None 0 3.87 kB sindresorhus
npm/[email protected] None 0 3.75 kB electerious
npm/[email protected] environment +1 7.55 kB sindresorhus
npm/[email protected] None 0 3.11 kB sindresorhus
npm/[email protected] None 0 7.39 kB sindresorhus
npm/[email protected] None 0 5.05 kB sindresorhus
npm/[email protected] None 0 4.37 kB sindresorhus
npm/[email protected] filesystem 0 3.32 kB sindresorhus
npm/[email protected] None 0 8.76 kB mafintosh
npm/[email protected] None 0 3.93 kB bcoe
npm/[email protected] environment, filesystem Transitive: shell +27 3.64 MB isaacs
npm/[email protected] None 0 4.22 kB bcoe
npm/[email protected] None 0 2.69 kB kevva
npm/[email protected] None 0 2.3 kB sindresorhus
npm/[email protected] None 0 9.96 kB isaacs
npm/[email protected] None 0 237 kB frangio
npm/[email protected] None 0 12.3 kB dominictarr
npm/[email protected] None 0 2.64 kB sindresorhus
npm/[email protected] None 0 12.5 kB dominictarr
npm/[email protected] None 0 66.8 MB typescript-bot
npm/[email protected] None 0 4.04 kB nexdrew
npm/[email protected] None 0 9.62 kB sindresorhus
npm/[email protected] environment, filesystem, shell 0 70.5 kB ivasilov
npm/[email protected] filesystem 0 11 kB oss-bot
npm/[email protected] environment 0 57.1 kB oss-bot
npm/[email protected] environment, filesystem 0 229 kB oss-bot

🚮 Removed packages: npm/@nomicfoundation/[email protected], npm/@openzeppelin/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Dec 10, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
Unrelated to this PR. These come from transitive dependencies.

@andrew-fleming andrew-fleming merged commit 8e8f10e into OpenZeppelin:master Dec 11, 2024
9 checks passed
@andrew-fleming andrew-fleming deleted the bump-cairo-to-v0.20.0 branch December 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants