Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cairo links when multiple components are imported #427

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ericglau
Copy link
Member

  • If multiple components are imported, link to the parent .cairo file with the same name as the last path segment
  • If a single component is imported, link to the file containing the component (if defined in the known mappings), otherwise link to the parent .cairo file with the same name as the last path segment

Fixes #423

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should add more entries to the components mapping, but we can do that in a separate PR.

@ericglau ericglau merged commit e1973f5 into OpenZeppelin:master Jan 17, 2025
9 checks passed
@ericglau ericglau deleted the cairolinks branch January 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cairo: Add hyperlinks to imports that have multiple items
2 participants