Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new private network endpoints #175

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Add new private network endpoints #175

merged 6 commits into from
Dec 8, 2023

Conversation

shahnami
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3113a3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Nov 23, 2023 •
edited
Loading

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

MCarlomagno
MCarlomagno previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pasevin
pasevin previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@pasevin pasevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shahnami shahnami dismissed stale reviews from pasevin and MCarlomagno via 3113a3b December 8, 2023 10:14
@shahnami shahnami merged commit f25c1fa into main Dec 8, 2023
5 checks passed
@shahnami shahnami deleted the plat-3356-expose-private-network-endpoint-to-sdk branch December 8, 2023 10:23
@shahnami shahnami mentioned this pull request Dec 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasevin pasevin pasevin approved these changes

@zeljkoX zeljkoX zeljkoX approved these changes

@LuisUrrutia LuisUrrutia Awaiting requested review from LuisUrrutia

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny dylankilkenny is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@MCarlomagno MCarlomagno Awaiting requested review from MCarlomagno MCarlomagno is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahnami @pasevin @zeljkoX @MCarlomagno