Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add address book client methods #589

Merged
merged 5 commits into from
Oct 15, 2024
Merged

feat: add address book client methods #589

merged 5 commits into from
Oct 15, 2024

Conversation

MCarlomagno
Copy link
Member

@MCarlomagno MCarlomagno commented Oct 8, 2024 •
edited
Loading

Summary

Adds new sub-package addressBook to list, create and delete address book entries.

Important: we must change the E2E API key to support the new capabilities (manage-address-book)

Testing Process

Included in e2e

Checklist

  • Add unit tests if applicable.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 45c1a89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dylankilkenny
dylankilkenny approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@dylankilkenny dylankilkenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socket-security Socket Security
Copy link

socket-security bot commented Oct 14, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

@MCarlomagno MCarlomagno merged commit 35fefcf into main Oct 15, 2024
9 checks passed
@MCarlomagno MCarlomagno deleted the plat-5417-create-sdk-api-for-create-get-and-listing-address-book branch October 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankilkenny dylankilkenny dylankilkenny approved these changes

@LuisUrrutia LuisUrrutia LuisUrrutia approved these changes

@collins-w collins-w Awaiting requested review from collins-w collins-w is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@emnul emnul Awaiting requested review from emnul emnul is a code owner

@shahnami shahnami Awaiting requested review from shahnami shahnami is a code owner

@tirumerla tirumerla Awaiting requested review from tirumerla tirumerla is a code owner

@zeljkoX zeljkoX Awaiting requested review from zeljkoX zeljkoX is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCarlomagno @LuisUrrutia @dylankilkenny