Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relayer-signer): Predefine auth config type for relayer signer c… #599

Merged
merged 3 commits into from
Oct 28, 2024
Merged

feat(relayer-signer): Predefine auth config type for relayer signer c… #599

merged 3 commits into from
Oct 28, 2024

Conversation

zeljkoX
Copy link
Contributor

@zeljkoX zeljkoX commented Oct 24, 2024

Predefine authConfig type for relayer signer client.

Summary

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1819eb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

shahnami
shahnami approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MCarlomagno
MCarlomagno approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zeljkoX zeljkoX merged commit fa9e206 into main Oct 28, 2024
9 checks passed
@zeljkoX zeljkoX deleted the plat-5507-enable-use-of-relayer-signer-package-without-specifying branch October 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCarlomagno MCarlomagno MCarlomagno approved these changes

@shahnami shahnami shahnami approved these changes

@collins-w collins-w Awaiting requested review from collins-w collins-w is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny dylankilkenny is a code owner

@emnul emnul Awaiting requested review from emnul emnul is a code owner

@tirumerla tirumerla Awaiting requested review from tirumerla tirumerla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeljkoX @shahnami @MCarlomagno