Add more standard gateway adapters #13
Draft
+2,444
−1,923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1f803e.
frangio
commented
Sep 18, 2024
| bytes32 outboxId, | ||
| uint256 maxSubmissionCost, | ||
| address excessFeeRefundAddress, | ||
| address callValueRefundAddress, |
There was a problem hiding this comment.
I think this value should not be a post-processing parameter, but should be set to the sender. This address will get all the call value back, and it may also be able to cancel the ticket.
xdaluca
reviewed
Oct 3, 2024
There was a problem hiding this comment.
@frangio I was wondering if we have been in touch with the Wormhole team regarding this?
There was a problem hiding this comment.
No, this was an internal experiment.
ernestognw
force-pushed
the
cross-chain/prototype-v1
branch
from
6828304 to
b173eed
Compare
Base automatically changed from
cross-chain/prototype-v1
to
crosschain-audit-oct-2024
November 29, 2024 19:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.